#2763#424
Merged
Merged
Conversation
fix phpcs/phpstan
fix phpcs/phpstan
fix phpcs/phpstan
fix phpcs/phpstan
fix phpcs/phpstan
fix phpcs/phpstan
3 tasks
A few small tweaks
The 150-character summary limit was only a soft hint: the eventseries form textarea carried an HTML #maxlength and the AI-suggestion helper trimmed its output, but neither is server-enforced, so a hand-entered or pasted summary could be saved at any length and the events API returned it verbatim (e.g. a 648-char summary failing the events-api 150-char spec). Add a server-side check in access_events_eventseries_validate that rejects a summary over 150 characters, reading summary_text from raw input the same way the save handler does. Also cap the value in the SearchApiPlainText views field so the API output respects the limit for historical data already over 150.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe context / purpose for this PR
Access module phpcs/phpstan fixes
Issue link
https://cyberteamportal.atlassian.net/browse/D8-2763
Any other related PRs?
Link to MultiDev instance
http://md-2763-accessmatch.pantheonsite.io
Checklist for PR author